Skip to content

[Synapse]fix remove artifact throw exception ArgumentNullException #28123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2025
Merged

[Synapse]fix remove artifact throw exception ArgumentNullException #28123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6755aa
fix responseContent?.ToString() throw exception ArgumentNullException
kevinzz6 Jul 3, 2025
1483dcf
update changelog
kevinzz6 Jul 3, 2025
e92fe45
Update src/Synapse/Synapse/Common/Utils.cs
kevinzz6 Jul 3, 2025
fc0aa04
Merge branch 'Fix-synapse-remove-artifact-issue' of https://github.co…
kevinzz6 Jul 3, 2025
47c30a3
check result.ContentStream == null
kevinzz6 Jul 3, 2025
9f9428e
Update ChangeLog.md
kevinzz6 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Synapse/Synapse/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
-->

## Upcoming Release

* Fixed an error when remove artifact throw `ArgumentNullException`
## Version 3.2.1
* Fixed an error of not correctly setting the cmdlet context

Expand Down
10 changes: 7 additions & 3 deletions src/Synapse/Synapse/Common/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,14 @@ public static Response Poll(this Operation operation)
{
var result = operation.WaitForCompletionResponseAsync().Result;
var responseContent = result.Content;

if (responseContent?.ToString() != "{}" && responseContent?.ToString().IsEmptyOrWhiteSpace() == false)
{

//Fix when responseContent.length is 0 responseContent?.ToString() will throw exception ArgumentNullException
if (result.ContentStream == null || result.ContentStream.Length == 0)
{
return result;
}
else if (responseContent?.ToString() != "{}" && responseContent?.ToString().IsEmptyOrWhiteSpace() == false)
{
throw new Exception(responseContent?.ToString());
}
return result;
Expand Down