Skip to content

Fix hardcode password in one example #28132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Fix hardcode password in one example #28132

merged 1 commit into from
Jul 4, 2025

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Jul 4, 2025

Description

Address one hardcoded password in one example of Az.Oracle #27895

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 4, 2025 03:48
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a hardcoded password from the New-AzOracleAutonomousDatabase example and replaces it with a placeholder, and updates related metadata (generation IDs, GUIDs, versions, and project references).

  • Replaced plaintext "PowerShellTestPass123" with "******" in example and help docs
  • Updated module/project metadata: generation date, GUIDs, generate_Id, assembly version, and solution project path
  • Un-commented empty ScriptsToProcess and TypesToProcess in the module manifest

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Oracle/Oracle/help/New-AzOracleAutonomousDatabase.md Replaced hardcoded password with placeholder
src/Oracle/Oracle.Autorest/examples/New-AzOracleAutonomousDatabase.md Same placeholder update in generated example
src/Oracle/Oracle.Autorest/docs/New-AzOracleAutonomousDatabase.md Same placeholder update in documentation example
src/Oracle/Oracle.psd1 Un-commented ScriptsToProcess and TypesToProcess
src/Oracle/Oracle.Autorest/generate-info.json Bumped generate_Id
src/Oracle/Oracle.Autorest/docs/Az.Oracle.md Updated Module Guid
src/Oracle/Oracle.Autorest/Properties/AssemblyInfo.cs Bumped assembly version to 1.2.0
src/Oracle/Oracle.sln Updated Az.Oracle project GUID and path references

@YanaXu YanaXu merged commit a604f46 into main Jul 4, 2025
12 checks passed
@YanaXu YanaXu deleted the yeming/cred branch July 4, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants