Skip to content

[MCP] Patch working directory glitch #28146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 7, 2025
Merged

Conversation

notyashhh
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@notyashhh notyashhh requested a review from Copilot July 7, 2025 10:52
Copilot

This comment was marked as outdated.

@notyashhh notyashhh requested review from VeryEarly and Copilot July 7, 2025 12:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the MCP prompt flow and fixes a working-directory issue in the build utility.

  • Streamlines and clarifies step-by-step instructions in mcpprompt.md
  • Updates Autorest path references and placeholder syntax
  • Adjusts generateAndBuild to use execSync with a cwd option instead of an inline cd

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tools/Mcp/test/vscode/mcpprompt.md Reorganized and cleaned up stage instructions; updated readme refs
tools/Mcp/src/services/utils.ts Removed redundant inline cd, added cwd: workingDirectory to exec
Comments suppressed due to low confidence (1)

tools/Mcp/test/vscode/mcpprompt.md:77

  • There's an extra '<' before 'specification'; it should be $(repo)/specification/<swaggerFileSpecs> so the input-file path resolves correctly.
  - $(repo)/<specification/<swaggerFileSpecs>

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 458d977 into dev/mcp-server Jul 7, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yash/mcp-server branch July 7, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants