Fix unused parameter warning in win_http_transport.cpp. #6579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xitzhang
requested review from
RickWinter,
antkmsft,
vhvb1989 and
LarryOsterman
as code owners
added 2 commits
May 15, 2025 17:24
added 4 commits
May 15, 2025 18:41
…g/azure-sdk-for-cpp into feature/websocket_speech
antkmsft
approved these changes
May 16, 2025
There was a problem hiding this comment.
Thank you for the fix.
It started failing in the main branch too. I think it is now happening after an MSVC update.
I didn't review the CI changes much, but the change to the code looks good.
In any case, CI changes are going to your feature branch at this moment.
I am going to copy your fix to the code, with the exact same comment, to my PR going to main, this should make it easier to merge in the future.
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
May 16, 2025
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
May 17, 2025
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.