Disable libcurl SSL connection sharing #6581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
May 17, 2025
…he same change with libcurl >= 8.12, and also make future merging easier
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
May 17, 2025
…he same change with libcurl >= 8.12, and also make future merging easier
|
/azp run cpp - core, cpp - identity, cpp - storage, cpp - keyvault, cpp - tables, cpp - attestation, cpp - eventhubs, cpp - template, cpp - appconfiguration |
|
Azure Pipelines successfully started running 9 pipeline(s). |
antkmsft
commented
May 17, 2025
Comment on lines
7
to
12
| ### Breaking Changes | ||
|
|
||
| - [[#6535]](https://github.com/Azure/azure-sdk-for-cpp/issues/6535) Disable SSL caching for libcurl transport, which fixes using SSL connections when using libcurl >= 8.12. (A community contribution, courtesy of _[sushshring](https://github.com/sushshring)_) | ||
|
|
||
| ### Bugs Fixed | ||
|
|
There was a problem hiding this comment.
Before merging, I will move this section to "Bugs fixed", I just don't want to reset the status of CI pipelines now.
Suggested change
| ### Breaking Changes | |
| - [[#6535]](https://github.com/Azure/azure-sdk-for-cpp/issues/6535) Disable SSL caching for libcurl transport, which fixes using SSL connections when using libcurl >= 8.12. (A community contribution, courtesy of _[sushshring](https://github.com/sushshring)_) | |
| ### Bugs Fixed | |
| ### Breaking Changes | |
| ### Bugs Fixed | |
| - [[#6535]](https://github.com/Azure/azure-sdk-for-cpp/issues/6535) Disable SSL caching for libcurl transport, which fixes using SSL connections when using libcurl >= 8.12. (A community contribution, courtesy of _[sushshring](https://github.com/sushshring)_) | |
|
cc @sushshring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6535.
When running unit tests with libcurl >= 8.12, and
EnableCurlSslCachingistrue, Curl connection pool unit tests do fail.Everything is green when
EnableCurlSslCaching == false, so I propose to disable it, and remove the option.This PR verifies that setting that option does not fail when using libcurl < 8.12, #6574 verifies it with libcurl >= 8.12.