chore: fix underlyingAsset for test token and coins #6438
+291
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshsp
force-pushed
the
fix-ofc-decimalPlaces
branch
6 times, most recently
from
08b245e to
1b1da0d
Compare
mukeshsp
changed the title
manas-at-bitgo
approved these changes
Jul 14, 2025
abhishekagrawal080
approved these changes
Jul 14, 2025
mukeshsp
force-pushed
the
fix-ofc-decimalPlaces
branch
from
1b1da0d to
4f8c3cf
Compare
bitgoAaron
reviewed
Jul 14, 2025
There was a problem hiding this comment.
this is a potentially breaking change, several of our user interfaces were previously built under the assumption that the UnderlyingAsset provided an environment agnostic way of defining a coin. We should first do an alpha release and vet this change before merging to master
bitgoAaron
requested changes
Jul 14, 2025
There was a problem hiding this comment.
- please use conventional commit messages, this type of change is not a
chore, it should be a feature or fix. - please include BREAKING CHANGE, as we are now fundamentally re-defining what UnderlyingAsset is used for
- please do an alpha release & verify this change in bitgo-ui before proceeding with merges to master
mukeshsp
force-pushed
the
fix-ofc-decimalPlaces
branch
from
4f8c3cf to
63d692f
Compare
Ticket: WIN-6149 BREAKING CHANGE: The underlyingAsset should be set to the corresponding testnet asset if the coin belongs to a testnet. This PR refactors such tokens to ensure consistency.
mukeshsp
force-pushed
the
fix-ofc-decimalPlaces
branch
from
63d692f to
568c2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
underlyingAssetshould be set to the corresponding testnet asset if the coin belongs to a testnet. This PR refactors such tokens to ensure consistency.Ticket: WIN-6149