Skip to content

feat(account-lib): return hex broadcastable message string #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(account-lib): return hex broadcastable message string #6446

wants to merge 1 commit into from

Conversation

bhavidhingra
Copy link
Contributor

@bhavidhingra bhavidhingra commented Jul 14, 2025 •
edited
Loading

  1. In baseMessage.ts, the toBroadcastString() method now converts the JSON string to a hexadecimal format instead of returning the plain JSON.
  2. In baseMessageBuilderFactory.ts, the fromBroadcastString() method was updated to handle the new hex format by first converting it back to a string.
  3. Tests were updated in multiple files to account for this change:
    • Converting hex back to string before parsing
    • Updating test descriptions and expectations

TICKET: COIN-4755

@bhavidhingra bhavidhingra force-pushed the coin-4755-msg-signing-support-ada-sol branch from 5d17569 to 757d9f4 Compare July 14, 2025 11:29
@bhavidhingra bhavidhingra marked this pull request as ready for review July 14, 2025 12:04
@bhavidhingra bhavidhingra requested review from a team as code owners July 14, 2025 12:04
margueriteblair
margueriteblair reviewed Jul 14, 2025
View reviewed changes
examples/ts/build-message.ts
@@ -28,9 +29,12 @@ async function main() {
const wallet = await bitgo.coin(coin).wallets().get({ id });
console.log(`Wallet label: ${wallet.label()}`);

const adaTestnetDestinationAddress = 'addr_test1vz7xs7ceu4xx9n5xn57lfe86vrwddqpp77vjwq5ptlkh49cqy3wur';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called adaTestnetDestinationAddress if this is for account lib?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margueriteblair margueriteblair margueriteblair left review comments

@Taseen08 Taseen08 Awaiting requested review from Taseen08 Taseen08 is a code owner automatically assigned from BitGo/wallet-platform

@sasikumar-bitgo sasikumar-bitgo Awaiting requested review from sasikumar-bitgo sasikumar-bitgo is a code owner automatically assigned from BitGo/wallet-platform

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavidhingra @margueriteblair