Skip to content

Edited NDarray slice to default to original codec/clevel for recompression #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

lshaw8317
Copy link
Collaborator

@lshaw8317 lshaw8317 commented Apr 7, 2025

Slice would decompress data, get slice, and recompress by default using dflt_cparams. Changed to use codec, clevel and filters of original compressed data to recompress slice.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have a small suggestion.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrancescAlted FrancescAlted merged commit aba6103 into Blosc:main Apr 7, 2025
7 checks passed
@lshaw8317 lshaw8317 deleted the slice_update branch April 10, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants