Skip to content

Enable chaining of lazy expressions for logical operators #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

lshaw8317
Copy link
Collaborator

Forcibly add parenthesis on creation of lazyexpr via strings to ensure order-of-operations respected and smaller lazy expressions which compose a larger lazyexpr are executed first.
Also remove unnecessary data type modification of already-existing lazyexpr when creating new lazy expression based on this already-existing lazyexpr.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrancescAlted FrancescAlted merged commit 1e9dc5c into Blosc:main Apr 29, 2025
7 checks passed
@FrancescAlted
Copy link
Member

Thanks @lshaw8317 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants