Change parethesis handling #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| # TODO: Test the chaining of multiple persistent lazy expressions | ||
| # def test_chain_persistentexpressions(): |
There was a problem hiding this comment.
Remember to change this: test_chain_persistentexpressions -> test_chain_persistent_expressions. As a general rule, you must separate complete words with underscores. Also, 4 words should be a hard limit for names ;-)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parentheses are now only added (recursively) to an expression when one uses it to form other expressions. Saving and reloading the expression preserves the original user-provided expression.