-
Notifications
You must be signed in to change notification settings - Fork 214
Adds Github Action for PyPI release! #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3015248
to
61ffb51
Compare
Ok, I believe I have finally finished force pushing everything to get this to work fully. One thing I haven't done is test in a cuda environment, since I don't have an easily accessible one set up. If you can do that, that would be great(just installing the project into your environment with |
I just realized I completely forgot about windows support on the auto release |
Thanks a lot @purepani , I'll try to test both things ASAP and then I'll merge. This is super appreciated, thanks! |
Hmm I'm not sure if I have time in the near future to figure this out; will probably be at least early next week. Maybe it's better to just upload linux by itself(or upload windows manually with linux). |
In researching on my phone while waiting for stuff, I found that there aren't super great solutions for windows cuda CI without custom runners, since pretty much all of them seem to be a bit manual, but they should work. |
61ffb51
to
6bcfa65
Compare
thank @purepani . I am suddenly swamped with some stuff, so I will need to leave testing and mergin this for end of April, but I really want to do it, just letting you know you have time to faff around with this until then if you want :) |
I'll definitely do that :) |
897063e
to
290b8f4
Compare
85122f8
to
a2ee83d
Compare
0bd182a
to
218f9c0
Compare
218f9c0
to
b0c3ba4
Compare
b0c3ba4
to
8beaa04
Compare
2eba4f1
to
0751f54
Compare
0751f54
to
d9612fa
Compare
Right! Finally tested and working on a linux machine with CUDA! Anything else I should test before a merge? Once merged, I'll try to figure out how to make a pip package then for tigre |
I don't think you need to test anything else. Of course, a future step should be to get this working for windows though. I may or may not be able to get to it, but I do remember it was not tricky getting cuda toolkit installed on the GitHub runner. Maybe easiest to just use a conda environment for that. I may or may not be able to get to this in the future, but I've been procrastinating on my master's degree and need to get to finishing that for now. (Though feel free to ping me for questions!) There is https://test.pypi.org to test the workflow before going on actual pypi. You'll need to create a trusted publisher, and link it to the GitHub actions, and the GitHub environment. The documentation for that is here: https://docs.pypi.org/trusted-publishers/ The way the release workflow is triggered is creating a release, and have a branch named You can also upload manually to pypi on your computer. Just build a wheel and upload it(I don't remember the pip commands off the top of my head, but the uv commands are |
Feel free to ping me with any questions! |
Depends on #643.
This adds a github action for releasing to pypi. If you tag a commit with
v*
, the action will be triggered, and it will try and publish it. You'll have to set up this action as a "trusted publisher" on your pypi account for this to work.This uses an nvidia docker container to get cuda on the github runner. The runners don't have gpus, so you can't test with them(at least without custom runners), but you can at least build them