Skip to content

Fix Calculation of Compound Center of Masses #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 13, 2025
Merged

Fix Calculation of Compound Center of Masses #1822

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc1a8a3
Added a new method to help inspect compound shapes
XeuTap Apr 24, 2025
50d8af1
Extended Center of mass.
XeuTap Apr 24, 2025
d4049c6
Refactored Center method.
XeuTap Apr 25, 2025
f6bff72
Moved the compound-specific method implementation inside the child class
XeuTap Apr 25, 2025
c65378e
Added new test-case.
XeuTap Apr 25, 2025
34826b0
Rework
adam-urbanczyk May 11, 2025
0541e1c
Remove extra methods
adam-urbanczyk May 11, 2025
33f099a
Remove import
adam-urbanczyk May 11, 2025
841bbee
Add docstring
adam-urbanczyk May 11, 2025
30701ff
Black fix
adam-urbanczyk May 11, 2025
24f72db
Black fix
adam-urbanczyk May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add docstring
  • Loading branch information
@adam-urbanczyk
adam-urbanczyk authored May 11, 2025
commit 841bbee86d6e11803ee0bee8337283510754448c
3 changes: 3 additions & 0 deletions cadquery/occ_impl/shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,9 @@ def CombinedCenter(objects: Iterable["Shape"]) -> Vector:

@staticmethod
def _mass_calc_function(obj: "Shape") -> Any:
"""
Helper to find the correct mass calculation function with special compound handling.
"""

type_ = shapetype(obj.wrapped)

Expand Down