Skip to content

Add more trimming possibilities #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 13, 2025
Merged

Add more trimming possibilities #1833

merged 28 commits into from
May 13, 2025

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented May 2, 2025

  • polyline trim
  • pcurve construction
    • edgeOn
    • wireOn
    • faceOn
  • curved trim as an overload
  • tests
  • make _uvBounds, _Bounds "public"
  • docs

Advanced stuff for users living in the (u,v) space:
image
image
image

@adam-urbanczyk adam-urbanczyk marked this pull request as draft May 2, 2025 15:05
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (2ad954c) to head (1a9cdac).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1833      +/-   ##
==========================================
+ Coverage   95.56%   95.96%   +0.40%     
==========================================
  Files          28       28              
  Lines        7346     8274     +928     
  Branches     1110     1358     +248     
==========================================
+ Hits         7020     7940     +920     
- Misses        195      203       +8     
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review May 10, 2025 21:53
Copy link
Member

@lorenzncode lorenzncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! faceOn with thicken looks useful for say 3D text.

base = sphere(5)
face_text = faceOn(base.faces(), text("CadQuery", 1))
result = base - compound([f.thicken(-0.1) for f in face_text.Faces()])

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @adam-urbanczyk !

@adam-urbanczyk adam-urbanczyk merged commit 1b2c7fd into master May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants