-
Notifications
You must be signed in to change notification settings - Fork 781
chore(wren-ai-service): minor updates #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update refactors prompt construction across several SQL-related pipelines by introducing distinct instruction categories for calculated fields and metrics, and reformatting user instructions as numbered lists. It also removes all references to current time or date from prompts and function signatures, and centralizes some prompt templates and rules into shared utilities. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Pipeline
participant PromptBuilder
participant Utils
User->>Pipeline: Submit query and context
Pipeline->>Utils: construct_instructions(config, instructions)
Utils-->>Pipeline: Return list of instructions
Pipeline->>PromptBuilder: Build prompt with calculated_field_instructions, metric_instructions, user_instructions
PromptBuilder-->>Pipeline: Return formatted prompt
Pipeline-->>User: Return SQL or recommendations
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary by CodeRabbit