Skip to content

feat: (daemon) saves default RPC token and (CLI) consumes it automatically #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 7, 2025

Summary of changes

Changes introduced in this pull request:

  • update daemon to save RPC token to {data_dir}/token by default, to align with Lotus
  • update CLI to consume the default token

Reference issue to close (if applicable)

Closes #4745

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title feat: (daemon) saves default RPC token and (CLI) consumes it automati… feat: (daemon) saves default RPC token and (CLI) consumes it automatically May 7, 2025
@hanabi1224 hanabi1224 marked this pull request as ready for review May 7, 2025 10:55
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 7, 2025 10:55
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team May 7, 2025 10:55
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a changelog entry. Also, can any of the pages or existing scripts be simplified thanks to this?

@hanabi1224
Copy link
Contributor Author

Let's have a changelog entry. Also, can any of the pages or existing scripts be simplified thanks to this?

@LesnyRumcajs changelog, scripts and docs are updated.

@elmattic elmattic added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 7d7b478 May 7, 2025
45 checks passed
@elmattic elmattic deleted the hm/save-default-rpc-token branch May 7, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forest-cli requires FULLNODE_API_INFO to be explictly set while lotus does not when invoked on the same host of the daemon
3 participants