feat(gc): automatic scheduler for snapshot GC #5639
+107
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
elmattic and
sudo-shashank
and removed request for
a team
| @@ -48,6 +48,7 @@ process. | |||
| | `FOREST_CHAIN_INDEXER_ENABLED` | 1 or true | false | 1 | Whether or not to index the chain to support the Ethereum RPC API | | |||
| | `FOREST_MESSAGES_IN_TIPSET_CACHE_SIZE` | positive integer | 100 | 42 | The size of an internal cache of tipsets to messages | | |||
| | `FOREST_STATE_MIGRATION_DB_WRITE_BUFFER` | non-negative integer | 10000 | 100000 | The size of db write buffer for state migration (`~10MB` RAM per `10k` buffer) | | |||
| | `FOREST_SNAPSHOT_GC_INTERVAL_EPOCHS` | non-negative integer | 20160 | 8000 | The interval in epochs for scheduling snapshot GC | | |||
There was a problem hiding this comment.
Shouldn't it be a positive integer? Or in other words, what would 0 in the interval mean? On every CPU cycle?
There was a problem hiding this comment.
0 means running GC continuously, which does not make a significant difference from 1
src/db/gc/snapshot.rs
Outdated
| } | ||
| } | ||
| } | ||
| tokio::time::sleep(Duration::from_secs(60 * 5)).await; |
| "Using snapshot GC interval epochs {i} set by FOREST_F3_BOOTSTRAP_EPOCH" | ||
| ) | ||
| }) | ||
| .unwrap_or(EPOCHS_IN_DAY * 7); |
There was a problem hiding this comment.
Is this documented anywhere?
There was a problem hiding this comment.
The default value of the env var
|
@hanabi1224 What about this piece of documentation? https://docs.forest.chainsafe.io/guides/gc |
sudo-shashank
approved these changes
May 19, 2025
There was a problem hiding this comment.
@hanabi1224 we should also update the gc guide to include info about new env vars and default values
|
@LesnyRumcajs @sudo-shashank doc updated |
sudo-shashank
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist