Skip to content

Fix tests failing #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Fix tests failing #406

merged 5 commits into from
May 15, 2025

Conversation

JMGilbert
Copy link
Contributor

@JMGilbert JMGilbert commented May 13, 2025

Tests have been failing I think related to this issue. I tried a suggestion in there and it seems to have worked.

@JMGilbert JMGilbert marked this pull request as ready for review May 13, 2025 21:05
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (0cc033c) to head (e43567d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files          15       15           
  Lines        1750     1750           
=======================================
  Hits         1206     1206           
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JMGilbert
Copy link
Contributor Author

I probably will not want to merge this. Trying to fix dependabot/pip/zarr-3.0.5 instead.

@kemccusker
Copy link
Member

kemccusker commented May 15, 2025

Note that this PR sets the version of numcodecs to work with zarr < 3, and we will separately deal with the zarr package upgrade and presumably at that point need to update numcodecs as well. Based on convos with @JMGilbert, this version of numcodecs will need to be upgraded once we update our zarr package to v3. (Please correct me though, @JMGilbert)

@kemccusker kemccusker merged commit 4294b90 into main May 15, 2025
4 checks passed
@kemccusker kemccusker deleted the fix_tests branch May 15, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants