Use Vendor message types for mctp-bench, mctp-echo #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctp-bench now uses a distinct message type instead of PLDM. Signed-off-by: Matt Johnston <[email protected]>
mctp-req and mctp-echo now use a distinct message type instead of PLDM. The length argument is the length of the "payload", with an additional 3 bytes added for message type. The first buffer byte is no longer printed (it would be incorrect for len=0 regardless). Signed-off-by: Matt Johnston <[email protected]>
mkj
force-pushed
the
dev/matt/vendor-msg-type
branch
from
756a308 to
47042a8
Compare
jk-ozlabs
reviewed
May 15, 2025
| @@ -116,6 +121,12 @@ static int handle_incoming_msg(struct recv_ctx *recv_ctx) | |||
| } | |||
|
|
|||
| hdr = (struct msg_header *)recv_ctx->buf; | |||
| if (memcmp(hdr->vendor_prefix, VENDOR_TYPE_BENCH, sizeof(VENDOR_TYPE_BENCH)) != 0) { | |||
There was a problem hiding this comment.
We should check that we have at least sizeof(VENDOR_TYPE_BENCH).
But I guess we're not checking that we have a full header either; we should probably add that, before the initial (struct msg_header *) cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously PLDM message type (1) was being used, but it would be better to use a specific type that won't conflict with other uses.
This could still clash with other vendor types, pending future kernel support to distinguish those.