Heading #12
Open
Heading #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazyPython
requested changes
Jan 7, 2021
There was a problem hiding this comment.
@codestance, feel free leave a review here (or contribute something else) 😄
| @@ -504,6 +529,7 @@ <h3>Key</h3> | |||
| </table> | |||
| </main> | |||
| <div style="position: relative; bottom: 90ch"> | |||
| <footer> | |||
| @@ -20,6 +20,28 @@ | |||
| table { border-spacing: 1px 4px; } | |||
| body { font-family: Arial, sans-serif; } | |||
|
|
|||
| body{ background-image: linear-gradient(90deg, orange 60%, cyan); } /* Added a background colour */ | |||
There was a problem hiding this comment.
I think you forgot to separate this line– mind removing this line?
| @@ -20,6 +20,28 @@ | |||
| table { border-spacing: 1px 4px; } | |||
| body { font-family: Arial, sans-serif; } | |||
|
|
|||
| body{ background-image: linear-gradient(90deg, orange 60%, cyan); } /* Added a background colour */ | |||
|
|
|||
| .intro{ /*for making the top heading in center*/ | |||
There was a problem hiding this comment.
Hmmm, I'm not sure it would look better with everything centered– human reading starts from the left, after all. I suppose it might look nicer if we moved the key and heading towards the center, but kept them left-aligned. I'm not sure this looks good when the key isn't also centered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the heading at the top center. Also made the footer part more nice.