-
Notifications
You must be signed in to change notification settings - Fork 3
[DAT-18825] Oracle Datapump restore failing with ORA-14650 and ORA-00942 errors #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ddb
Are you sure you want to change the base?
Conversation
…and all others order should be unchanged
…and all others order should be unchanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @v-petrovych, left a few comments
liquibase-core/src/main/java/liquibase/database/AbstractJdbcDatabase.java
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Outdated
Show resolved
Hide resolved
liquibase-core/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Show resolved
Hide resolved
… key, thus we can track all tables referencing integrity in Dependency Graph via 'R' constraint instead of drop all constraints in the very beginning of 'dropAll' operation
liquibase-core/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liquibase core SQL is different: https://github.com/liquibase/liquibase/blob/2c2170ec0be7c47f0684037d27a6488eb5f4d3f1/liquibase-standard/src/main/java/liquibase/diff/output/changelog/DiffToChangeLog.java#L584
The only thing I would mention is the AND NOT(NAME LIKE 'BIN$%')
- would it makes sense here too?
I was going to do the same and not sure adding this condition would make query to perform better. Did we run any performance tests? |
Hi @filipelautert, the line which you mentioned is also present in our code base (in the same class where we make changes in queryForDependenciesOracle method and it creates a graph based on Oracle _DEPENDENCIES table), the change we make in this PR is that we add an additional query to see FK dependencies to be able to add additional dependencies between tables because we can't drop FK if it is a partitioning reference FK. |
Hi @suryaaki2, on enterprise side we haven't run performance tests to compare results with or without AND NOT(NAME LIKE 'BIN$%') yet if this question was directed to our team (but most probably it was directed to @filipelautert) |
No description provided.