Skip to content

CardView: fix selection (throw error if needed) (oqSw9T3c) #29873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025
Merged

CardView: fix selection (throw error if needed) (oqSw9T3c) #29873

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa17d31
CardView: fix selection (throw error if needed) (oqSw9T3c)
haksur May 14, 2025
67ffef8
CardView: fix selection (throw error if needed) (oqSw9T3c) (review co…
haksur May 19, 2025
8f4cbc9
CardView: editing operations, add/edit/delete (throw error if needed)…
haksur May 19, 2025
79b1ff7
CardView: fix selection (throw error if needed) (oqSw9T3c) (review co…
haksur May 20, 2025
3f0e7c6
Update packages/devextreme/js/__internal/grids/new/grid_core/selectio…
haksur May 20, 2025
8c432c7
Update packages/devextreme/js/__internal/grids/new/grid_core/selectio…
haksur May 20, 2025
84fd185
Update packages/devextreme/js/__internal/grids/new/grid_core/selectio…
haksur May 20, 2025
8288369
CardView: fix selection (throw error if needed) (oqSw9T3c) (review co…
haksur May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/devextreme/js/__internal/grids/new/grid_core/selectio… 
…n/controller.integration.test.ts

Co-authored-by: wdevfx <[email protected]>
Signed-off-by: haksur <[email protected]>
  • Loading branch information
@haksur @wdevfx
haksur and wdevfx authored May 20, 2025
commit 8c432c74692def74bcdea68ca07362a5ecb0dcac
2 changes: 1 addition & 1 deletion ...ges/devextreme/js/__internal/grids/new/grid_core/selection/controller.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('when keyExpr is missing', () => {
});

describe('selection mode single', () => {
it('shouldn\'t throw E1042 error if keyExpr is missing and selection', () => {
it('shouldn\'t throw E1042 on initial startup', () => {
setup({
dataSource: [{ value: 'test1' }, { value: 'test2' }],
selection: {
Expand Down
Loading