bump ImGui to 1.91 #248
Open
bump ImGui to 1.91 #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sDown[] are removed (obsoleted February 2022). according to ImGui CHANGELOG.txt and explicitly indicate shader language for ImGui VS & ImGui PS, to avoid getting error on shader compilation.
|
How this change is supposed to work with the current version of ImGui? |
I merged this patch with DiligentTools in a fresh cloned DiligentEngine and replace ThirdParty/imgui with the official one (v1.91) , that's all. |
|
This change can't be merged. First of all, it breaks the build because it does not update the ImGui. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump ImGui to 1.91, see #246 , io.KeyMap[] and io.KeysDown[] are removed, according to ImGui CHANGELOG.txt
and explicitly indicate shader language for ImGui VS & ImGui PS, to avoid getting error on shader compilation.
ThirdParty/imguineeds to be sync.