Use TypeScript compiler for Hypergrid JS build #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbloom
commented
Oct 13, 2020
src/Hypergrid/events.js
Outdated
| this.mouseDownState = null; | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Incorrectly deleted.
aaronbloom
force-pushed
the
feature/update-jsdoc-for-ts-compiler
branch
from
a989dbb to
5b42556
Compare
aaronbloom
changed the title
aaronbloom
commented
Feb 2, 2021
|
|
||
| callback(null, content); // the first argument is an error, if you encounter one | ||
| let filename = path.basename(file.path, "." + type); | ||
| callback(null, `exports.${filename} = \`\n${content}\`;\n`); // the first argument is an error, if you encounter one |
There was a problem hiding this comment.
Updated to use ` string literals as previously it would output an bad format.
Generally this gulp file should be removed and replace with independent common commands for linting etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.