Skip to content

Add odd length reading strategy fod Dicom Dump #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

jmlaka
Copy link
Contributor

@jmlaka jmlaka commented Apr 12, 2025

added option to change the default "accept" odd length text strategy for the dicom-dump reader.

Comes in handy for ruling out padding / length problems in dicom files.

@Enet4 Enet4 added enhancement A-tool Area: tooling C-dump Crate: dicom-dump labels Apr 15, 2025
@Enet4 Enet4 self-requested a review April 15, 2025 17:50
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Just pointing some suggestion inline.

(you can also try rebasing the branch to make the Clippy errors go away)

Co-authored-by: Eduardo Pinho <[email protected]>
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Enet4 Enet4 merged commit 3a0dd76 into Enet4:master May 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tool Area: tooling C-dump Crate: dicom-dump enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants