Skip to content

[AN-Issue-#1968] Api to get task details in bulk #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

aregng
Copy link

@aregng aregng commented May 30, 2025

Compared the data retrieval and deserialization when retrieving

  • 500 tasks :
    • step by step using AptosVmViewer (~28 secs)
    • in 25 bulk using ApotsVmViewer (~14 secs)
  • 5000 tasks:
    • step by step using AptosVmViewer (~454ms)
    • in 25 bulk using ApotsVmViewer (~163ms)

The bulk retrieval only showed 2-3x of acceleration.
Why 25 tasks because of the experiments results that Nizam did and shared the result in this thread: https://supraoracles.slack.com/archives/C07TE2ZRX2R/p1732282031414689

Comment on lines +423 to +425
let inner_entry_function =
aptos_framework_sdk_builder::supra_coin_mint(dest_account.address().clone(), (i + 1) * 10)
.into_entry_function();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to register a task with a large payload to verify whether the get_task_details_bulk view function can handle a response with 500 tasks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I just saw that we only need to return 25 tasks, so in that case, it works fine.

@aregng aregng merged commit 32280db into release/v1.6 Jun 2, 2025
1 check passed
@aregng aregng deleted the task/issue-1968 branch June 2, 2025 07:17
aregng added a commit that referenced this pull request Jun 2, 2025
aregng added a commit that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants