-
Notifications
You must be signed in to change notification settings - Fork 5.4k
improve dbg intrinsic with fflush #7126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+69
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7126 will not alter performanceComparing Summary
|
zees-dev
reviewed
Apr 28, 2025
Can you maybe explain the rationale for this? Is there a reason the output cannot be flushed as it arrives? Maybe due to performance reasons on the consumer side? |
It can. The hardest part is to know when '__dbg' stops printing. This will allow 'EcalHandlers' to print the whole thing as just one string when needed. |
kayagokalp
approved these changes
Apr 29, 2025
tritao
approved these changes
Apr 29, 2025
zees-dev
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings a new syscall "fflush" to help
EcalHandler
know when the__dbg
is finished and they flush their buffers.In theory, Linux
fflush
is not a syscall because it just flushes "user-space" buffers. As we do not have this difference, we are still going to callfflush
as a syscall.Checklist
Breaking*
orNew Feature
labels where relevant.