Skip to content

Parse raw identifiers (r#<identifier>) in expressions #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Apr 30, 2025

Description

This PR fixes several issues related to raw identifiers (r#<identifier>). The focus was to fix only the major issue that was preventing the planned migration step for panic expression to be implemented. The planned step "Rename existing "panic" identifiers" will replace all eventual occurrences of panic with r#panic. For that, it was crucial to get raw identifiers being properly parsed in expressions.

The PR:

Some remaining issues related to raw identifiers are documented in #7136.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev self-assigned this Apr 30, 2025
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser labels Apr 30, 2025
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Performance Report

Merging #7137 will not alter performance

Comparing ironcev/keywords-as-raw-identifiers (349d310) with master (42321ef)

Summary

✅ 22 untouched benchmarks

@ironcev ironcev marked this pull request as ready for review April 30, 2025 14:00
@ironcev ironcev requested a review from a team as a code owner April 30, 2025 14:00
@ironcev ironcev enabled auto-merge (squash) April 30, 2025 14:00
@IGI-111 IGI-111 requested a review from a team May 1, 2025 04:28
@ironcev ironcev merged commit 40cffb2 into master May 1, 2025
41 checks passed
@ironcev ironcev deleted the ironcev/keywords-as-raw-identifiers branch May 1, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
3 participants