-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Replace Tokio Thread File Watcher with LSP Client File Watcher #7147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did_change_watched_files
instead of in a tokio thread
did_change_watched_files
instead of in a tokio thread
CodSpeed Performance ReportMerging #7147 will not alter performanceComparing Summary
|
…ange_watched_files instead
…changes in the file watcher.
…gistration in the language server.
… registration to initialized method.
4d0b9a3
to
e0a4646
Compare
zees-dev
approved these changes
May 5, 2025
IGI-111
approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always nice to see a PR with net negative line count!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces our custom Tokio-based thread watcher for
Forc.toml
files with the built-in LSPdidChangeWatchedFiles
notification system. The changes:Forc.toml
file changes through the LSP notification protocolThis approach is more efficient as it leverages the client's native file watching capabilities rather than spawning a separate thread. The PR maintains the same functionality while reducing resource usage and complexity.
Note: This doesn't yet implement the recompilation on
Forc.toml
changes as mentioned in issue #7103, but adds a TODO placeholder for that functionality.This PR is a precursor to #7139
Checklist
Breaking*
orNew Feature
labels where relevant.