Skip to content

feat: add SizeLimit support to FileUploadConfig #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

Conversation

SubashPradhan
Copy link
Contributor

Submit a pull request

  • Add SizeLimit to FileUploadConfig

CLA

  • [*] I have signed the Stream CLA (required).
  • [*] The code changes follow best practices
  • [*] Code changes are tested (add some information if not applicable)

Description of the pull request

totalimmersion
totalimmersion previously approved these changes Jun 30, 2025
app_test.go Outdated
// First, set up file upload config with size limit
sizeLimit := 5242880 // 5MB
fileUploadConfig := &FileUploadConfig{
AllowedFileExtensions: []string{".jpg", ".png"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you include .txt as well? The other test that was failing, will try to upload a text file. If you allow .txt, we can be assured the other test will never be impacted, as an extra precaution

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added .txt on both tests 🎉

@totalimmersion totalimmersion self-requested a review July 3, 2025 07:14
@SubashPradhan SubashPradhan merged commit 5f4e213 into master Jul 9, 2025
8 of 11 checks passed
@SubashPradhan SubashPradhan deleted the CHA-955 branch July 9, 2025 07:51
@github-actions github-actions bot mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants