-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: auth on forked repos #4087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @davidcavazos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where authentication was failing in forked repositories. The changes involve updating the workflow files to ensure that checkout and authentication are handled within their own steps, as the setup-custard
tool no longer automatically manages this process. The changes consist of adding a comment to two files, run/helloworld/index.js
and tpu/createVM.js
, which appears to be a temporary addition for testing purposes.
Highlights
- Authentication Fix: The primary goal of this PR is to resolve authentication problems encountered when working with forked repositories.
- Workflow Updates: The pull request modifies workflow configurations to explicitly handle checkout and authentication steps.
- Temporary Comments: The pull request adds temporary comments to
index.js
andcreateVM.js
files, likely for testing triggers.
Changelog
- run/helloworld/index.js
- Added a temporary comment '// TODO: remove this comment, used to trigger tests'.
- tpu/createVM.js
- Added a temporary comment '// TODO: remove this comment, used to trigger tests'.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A fork in the repo's way,
Auth errors caused dismay.
Workflows now aligned,
Authentication defined,
Tests pass, hip hip hooray!
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds temporary comments to trigger tests. These comments should be removed once the tests are properly configured.
Summary of Findings
- Temporary comments: The added comments are intended for temporary use and should be removed after serving their purpose.
Merge Readiness
The pull request introduces temporary comments for testing purposes. It is crucial to remove these comments once the tests are correctly set up. I am unable to approve the pull request, and users should have others review and approve this code before merging. I recommend addressing the removal of these comments before merging.
Description
To fetch the correct repo, checkout and auth are now explicitly made instead of them being part of setup-custard. This functionality was removed from setup-custard on v0.3.2.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.