-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(genai): Add GenAI SDK samples (1) #4093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @gericdong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds initial samples for the GenAI SDK, specifically focusing on text generation. It includes a package.json file to manage dependencies, a test file (textgen-with-txt.test.js) to verify the text generation functionality, and the text generation code itself (textgen-with-txt.js). The code uses the @google/genai
library to generate text content from a text prompt using the gemini-2.0-flash
model.
Highlights
- Text Generation Sample: Adds a sample demonstrating text generation using the GenAI SDK.
- Dependencies: Introduces necessary dependencies like
@google/genai
,axios
,supertest
,c8
,chai
,mocha
,sinon
, anduuid
. - Testing: Includes a test case to ensure the text generation functionality works as expected.
Changelog
Click here to see the changelog
- genai/package.json
- Added a
package.json
file to manage project dependencies and scripts. - Includes dependencies for
@google/genai
,axios
, and testing libraries. - Defines a test script using
c8
andmocha
.
- Added a
- genai/test/textgen-with-txt.test.js
- Created a test file to verify the text generation functionality.
- Uses
chai
for assertions andmocha
for testing. - Tests the
generateContent
function fromtextgen-with-txt.js
.
- genai/text-generation/textgen-with-txt.js
- Implements the text generation functionality using the
@google/genai
library. - Defines a
generateContent
function that takes a project ID and location as parameters. - Uses the
gemini-2.0-flash
model to generate text content from the prompt 'How does AI work?'.
- Implements the text generation functionality using the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A model stands tall,
Answering questions for all,
With text it replies,
Under digital skies,
AI's wisdom enthralls.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new GenAI SDK sample for text generation using a text prompt. The code includes a sample application and a corresponding test case. Overall, the code is well-structured and easy to understand. However, there are a few areas that could be improved.
Summary of Findings
- Prompt Specificity: The prompt 'How does AI work?' is quite broad. A more specific prompt would likely yield more interesting and relevant results.
- Error Handling: The
generateContent
function lacks error handling. Adding a try-catch block would improve the robustness of the code. - Test Assertion Specificity: The test case only checks if the output length is greater than 0. A more specific assertion would ensure the generated content is relevant.
- Model Configuration: The model is hardcoded. Making it configurable would allow users to easily switch between different models.
Merge Readiness
The pull request introduces a functional GenAI sample. Addressing the suggestions would enhance the sample's robustness, flexibility, and testability. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
Here is the summary of changes. You are about to add 8 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes b/415995543 - Add GenAI SDK samples (1)