Skip to content
This repository was archived by the owner on Apr 2, 2019. It is now read-only.

Respect Leading Zeros in Initial Render Pass #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Respect Leading Zeros in Initial Render Pass #156

wants to merge 1 commit into from

Conversation

Kelderic
Copy link

@Kelderic Kelderic commented Apr 5, 2018

Currently, an element that is initialized while having a textContent of
"000", will be shown as "0". This commit takes a snapshop of the initial
value, and then uses that snapshot in the initial render pass, rather
than converting the string to a number and then back to a string. This
respects leading zeros.

Currently, an element that is initialized while having a textContent of
"000", will be shown as "0". This commit takes a snapshop of the initial
value, and then uses that snapshot in the initial render pass, rather
than converting the string to a number and then back to a string. This
respects leading zeros.
@eads
Copy link

eads commented Sep 20, 2018

This is neat, but didn't work for me ... only doing this during the initial rendering pass caused problems after the initial rendering pass. If I have time I might play with this to respect zero fill during every render pass.

I think this is a great approach to the zero fill problem -- simply let the value dictate how to zero-fill.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants