Skip to content

feat: Private sharing button #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2025
Merged

feat: Private sharing button #1617

merged 8 commits into from
Jun 5, 2025

Conversation

Muuushuuu
Copy link
Contributor

No description provided.

@Muuushuuu Muuushuuu force-pushed the private-sharing-button branch from a44b027 to 16e35e1 Compare May 28, 2025 11:02
@FabianDevel FabianDevel requested a review from sirambd May 28, 2025 12:25
Copy link
Member

@sirambd sirambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make the public share settings show then hide by default, it looks very ugly.
But make them gone by default, then show only when needed.

@Muuushuuu Muuushuuu force-pushed the private-sharing-button branch from c93123c to 36f5381 Compare June 4, 2025 07:23
@Muuushuuu Muuushuuu requested a review from sirambd June 4, 2025 07:24
@Muuushuuu Muuushuuu enabled auto-merge June 4, 2025 08:00
@Muuushuuu Muuushuuu force-pushed the private-sharing-button branch from a1850fd to edeb92b Compare June 4, 2025 09:50
@tevincent tevincent added the rebase Add this label to rebase the PR label Jun 5, 2025
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 5, 2025
@KevinBoulongne KevinBoulongne force-pushed the private-sharing-button branch from edeb92b to e8f3660 Compare June 5, 2025 08:16
@Muuushuuu Muuushuuu force-pushed the private-sharing-button branch from dd5a1c9 to 9dd4d4e Compare June 5, 2025 09:29
@Muuushuuu Muuushuuu force-pushed the private-sharing-button branch from 9dd4d4e to 83f3ef1 Compare June 5, 2025 09:47
Copy link

sonarqubecloud bot commented Jun 5, 2025

@Muuushuuu Muuushuuu merged commit 3a41c05 into main Jun 5, 2025
6 checks passed
@Muuushuuu Muuushuuu deleted the private-sharing-button branch June 5, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants