-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Private sharing button #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
approved these changes
May 27, 2025
sirambd
requested changes
May 27, 2025
app/src/main/java/com/infomaniak/drive/views/ShareLinkContainerView.kt
Outdated
Show resolved
Hide resolved
a44b027
to
16e35e1
Compare
sirambd
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make the public share settings show then hide by default, it looks very ugly.
But make them gone by default, then show only when needed.
c93123c
to
36f5381
Compare
a1850fd
to
edeb92b
Compare
edeb92b
to
e8f3660
Compare
sirambd
approved these changes
Jun 5, 2025
dd5a1c9
to
9dd4d4e
Compare
… visibility management
9dd4d4e
to
83f3ef1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.