-
Notifications
You must be signed in to change notification settings - Fork 51
[compute] Move eq_ind_partial_eval helper function to library #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compute] Move eq_ind_partial_eval helper function to library #676
Conversation
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Oh, yes, thanks. |
Wait, that's not in |
402d5fa
to
dccb82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Send + Sync bounds were removed from Hal, the code I previously shared is now outdated.
This PR is good to merge as-is.
This moves a common function from a test helper method to the binius_compute crate library.
dccb82c
to
7bc907a
Compare
Merge activity
|
This moves a common function from a test helper method to the binius_compute crate library. Renamed function to reduce confusion with ComputeLayerExecutor::tensor_expand and to better match the function in `binius_math` crate that does the same functionality without the ComputeLayer.
This moves a common function from a test helper method to the binius_compute crate library.
Renamed function to reduce confusion with ComputeLayerExecutor::tensor_expand and to better match the function in
binius_math
crate that does the same functionality without the ComputeLayer.