Skip to content

[compute] Move eq_ind_partial_eval helper function to library #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jimpo
Copy link
Collaborator

@jimpo jimpo commented Jun 8, 2025

This moves a common function from a test helper method to the binius_compute crate library.

Renamed function to reduce confusion with ComputeLayerExecutor::tensor_expand and to better match the function in binius_math crate that does the same functionality without the ComputeLayer.

Copy link
Collaborator Author

jimpo commented Jun 8, 2025


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jimpo jimpo requested a review from djadjka June 8, 2025 21:01
@jimpo jimpo marked this pull request as ready for review June 8, 2025 21:01
@djadjka
Copy link
Contributor

djadjka commented Jun 9, 2025

Copy link
Collaborator Author

jimpo commented Jun 9, 2025

Oh, yes, thanks.

Copy link
Collaborator Author

jimpo commented Jun 9, 2025

Wait, that's not in main yet though. Can you please take over this PR (you can gt submit to it) and make the improvements you want, including the tensor_prod_eq_ind method and the unit test. I don't have a preference between binius_compute::ops module and binius_core::math.

@jimpo jimpo changed the base branch from 06-08-_prodcheck_prodcheck_module_with_layer_computation to graphite-base/676 June 11, 2025 16:46
@jimpo jimpo force-pushed the graphite-base/676 branch from 5300324 to 9f4c9ef Compare June 11, 2025 16:46
@jimpo jimpo force-pushed the 06-08-_compute_move_eq_ind_partial_eval_helper_function_to_library branch from 402d5fa to dccb82c Compare June 11, 2025 16:46
@jimpo jimpo changed the base branch from graphite-base/676 to main June 11, 2025 16:46
Copy link
Contributor

@djadjka djadjka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Send + Sync bounds were removed from Hal, the code I previously shared is now outdated.
This PR is good to merge as-is.

This moves a common function from a test helper method to the binius_compute crate library.
@jimpo jimpo force-pushed the 06-08-_compute_move_eq_ind_partial_eval_helper_function_to_library branch from dccb82c to 7bc907a Compare June 12, 2025 07:19
Copy link

graphite-app bot commented Jun 12, 2025

Merge activity

  • Jun 12, 7:35 AM UTC: jimpo added this pull request to the Graphite merge queue.
  • Jun 12, 7:36 AM UTC: CI is running for this pull request on a draft pull request (#735) due to your merge queue CI optimization settings.
  • Jun 12, 7:53 AM UTC: Merged by the Graphite merge queue via draft PR: #735.

graphite-app bot pushed a commit that referenced this pull request Jun 12, 2025
This moves a common function from a test helper method to the binius_compute crate library.

Renamed function to reduce confusion with ComputeLayerExecutor::tensor_expand and to better match the function in `binius_math` crate that does the same functionality without the ComputeLayer.
@graphite-app graphite-app bot closed this Jun 12, 2025
@graphite-app graphite-app bot deleted the 06-08-_compute_move_eq_ind_partial_eval_helper_function_to_library branch June 12, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants