Skip to content

Display number of flushed entries in TableStat #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

shreyas-londhe
Copy link
Contributor

This PR resolves #341.

Copy link

graphite-app bot commented Jun 10, 2025

How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@shreyas-londhe
Copy link
Contributor Author

@pepyakin I am currently only exposing the total flush count in TableStat as I noticed that the prover cost is estimated by flush_count * table_capacity (as mentioned in the issue). But since the table_capacity is not know when TableStat is created, I'm not sure if this is the correct way to display the flush count. Would love to know your thoughts on this.

Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I think that was a brainfart on my side! Thanks so much!

@pepyakin pepyakin merged commit 5ef110e into IrreducibleOSS:main Jun 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display number of flushed entries
2 participants