-
Notifications
You must be signed in to change notification settings - Fork 175
Added namespace to build.gradle and updated flutter_foreground_task #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request makes two primary changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant Gradle as Gradle Build Process
participant Config as build.gradle
Gradle->>Config: Evaluate Android configuration
alt Namespace property exists
Config->>Gradle: Set namespace to "com.isvisoft.flutter_screen_recording"
else Namespace property not found
Gradle->>Config: Proceed with default configuration
end
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
flutter_screen_recording/android/build.gradle (1)
31-34
: Conditional Namespace Assignment for AGP CompatibilityThe conditional block that assigns the namespace only if the property exists (i.e.,
if (project.android.hasProperty("namespace"))
) is a good way to maintain compatibility with older versions of the Android Gradle Plugin. However, consider adding an inline comment that further explains:
- Why this conditional check is necessary.
- Which AGP versions require this handling.
This will help future maintainers understand the context behind this logic.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
flutter_screen_recording/android/build.gradle
(1 hunks)flutter_screen_recording/pubspec.yaml
(1 hunks)
🔇 Additional comments (1)
flutter_screen_recording/pubspec.yaml (1)
13-13
: Dependency Version Update – Verify CompatibilityThe dependency for
flutter_foreground_task
has been upgraded to^8.0.0
. Please ensure that any breaking changes or new requirements introduced in version 8.0.0 are compatible with the rest of the plugin, and update documentation or tests as necessary.
@salime45 kindly merge this solution, I am also facing the same issue on my end! |
The same issue happened with me as well. Kindly resolve it as early as possible. |
Android Gradle Plugin requirements
https://d.android.com/r/tools/upgrade-assistant/set-namespace
Summary by CodeRabbit