-
Notifications
You must be signed in to change notification settings - Fork 4.1k
'Default arguments' -> 'Default parameters' #4833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BTW, the spec also calls it "default parameters" https://kotlinlang.org/spec/declarations.html#named-positional-and-default-parameters |
Hmm, sorry, I maybe rushed a bit https://jetbrains.team/im/review/1AlVqg2AG16Y?message=C28bz0VH91z&channel=ei0qL1MCT31 I will make sure that we internally agree on the terminology and write back |
878687f
to
f8d605c
Compare
That's the middle ground that we kinda agreed on:
https://jetbrains.slack.com/archives/C06E082M6/p1746713347805569 |
f8d605c
to
61ed71f
Compare
Thanks for the detailed clarification! We'll work on it in the next few days. |
Hi again, @nikitabobko
Please let me know if I can help. Thanks. |
Yes, it's clear that I can update the links across the site, and I believe I already did that, but I will recheck. Anyway, my concern was about other sites that refer to kotlinlang.org |
61ed71f
to
d6d7af7
Compare
I had to force push because of merge conflicts. The first commit is untouched, it's just rebased
I've updated these docs as well. I've yet skipped
Done. I indeed missed a couple of other anchors |
…s not a parameter but an argument Summarization of the team discussion: - It's definitely ok to call it "optional parameters", but unfortunately it's not a wide-spread term - It's ok to say it in full "parameters with default values" - It's ok to say "default value" (if it's clear from the context) - "default parameters" and "default arguments" are slightly problematic and it's better to avoid them Discussion link: https://jetbrains.slack.com/archives/C06E082M6/p1746713347805569 The commit fixes two problems: 1. Avoid using "default arguments" and "default parameters" 2. Lambda is not a parameter. It's an expression, and it's an argument that corresponds to a parameter with functional type.
I missed some anchors in the previous commit
See the commit before the previous for motivation
e97ea6a
to
e37c5cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on these updates! 🚀 🚀
Two fixes:
I didn't touch anything in
docs/topics/whatsnew/*
because I don't consider them a part of the documentation but rather a piece of history that is written the way it's written.Similarly, I didn't touch the following files:
because they don't feel like a documentation to me. But let me know if you actually want me to update them
Further, I acknowledge that I'm changing the title of the section in
./docs/topics/functions.md
file which will break the existing URL links. I don't know what are the policy for doing that (if there are any). So please let me know if I just can't change it, or if there is a more "migration friendly" way to do that.Feel free to amend the commits as you please or let me know if there are changes that you want me to make, thanks