-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: legacy DCE deprecation #4885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb4ba84
to
6f779da
Compare
cb52003
to
42ee09b
Compare
docs/topics/js/js-ir-compiler.md
Outdated
@@ -124,6 +124,41 @@ kotlin { | |||
} | |||
``` | |||
|
|||
## Dead code elimination | |||
|
|||
[Dead code elimination](https://wikipedia.org/wiki/Dead_code_elimination) (DCE) or _tree shaking_ reduces the size of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the tree shaking, because it's a different process done by our tooling
7255ac2
to
5e40df5
Compare
@danil-pavlov it seems like after the last force push the changes a bit broken. |
91757bf
to
b1b0cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment for you to check.
@@ -463,7 +463,7 @@ perspective | |||
> **Incompatible change type**: source | |||
> | |||
> **Short summary**: remove the `kotlin2js` and `kotlin-dce-plugin` plugins. Instead of `kotlin2js`, use the new `org.jetbrains.kotlin.js` plugin. | |||
> Dead code elimination (DCE) works when the Kotlin/JS Gradle plugin is [properly configured](http://javascript-dce.md) | |||
> Dead code elimination (DCE) works when the Kotlin/JS Gradle plugin is properly configured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a link to js-ir-compiler.md#dead-code-elimination ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, this is an old compatibility entry (1.4-17 versions). the new section describes how DCE is handled in the new IR compiler
* update: update JVM target bytecode version 24 * update: updates for REPL in Kotlin 2.2.0 * Adding infromation to docs about JVM default method generation (#4867) * feat: adding infromation to docs about JVM default method generation * implementing review comments * implementing review comments for java to kotlin interop * implementing comments from TWr review * update: adding information about new context-sensitive resolution (#4865) * update: adding information about new context-sensitive resolution to documentation * implementing review comments * implementing TWr review comments * feat: stable non-local jumps (#4875) * feat: add section for read write annotations kotlin metadata (#4870) * feat: add note about experimental annotation support in Kotlin metadata * adding new section to increase visibility in docs * implementing comments from TWr review * update: ant warning (#4882) * update: new annotations defaulting rule and the new `all` meta-target (#4874) * feat: new compiler warning management (#4876) * feat: update JVM records for 2.2.0 * update: language updates for 2.2.0 release (#4873) * update: language updates for 2.2.0 release This PR contains doc updates about context parameters, guard conditions, and nested type aliases. * Daniel review * chore: fix typo Co-authored-by: Dániel Csorba <[email protected]> * add clarification about context receivers * Removing paragraph about context receivers --------- Co-authored-by: Dániel Csorba <[email protected]> * feat: add @JvmExposeBoxed annotation for 2.2.0 * update: Windows support in Native (#4879) * feat: add build tools API * feat: add BCV for KGP * chore: fix What's new version reference * update: update the statuses of language features for Kotlin 2.2.0 (#4901) * Update the statuses of language features for Kotlin 2.2 * fix: fix the status for Kotlin statics --------- Co-authored-by: Andrey Polyakov <[email protected]> * feat: add migration text from kotlinOptions{} * feat: add 2.2.0 compatibility guide document (#4877) * feat: first language tickets for compatibility guide This update includes the first batch of language tickets to be included in the 2.2.0 compatibility guide * updating compatibility guide draft with language and stdlib tickets * update: kotlin-android-extensions deprecation * adding build tools features to the compatibility guide * implementing build tools review comments * implementing additional small comment * Kotlin scripting update * feat: multiplatform compatibility issues * chore: header * fix: review suggestions Co-authored-by: Sarah Haggarty <[email protected]> * fix: review suggestions * implementing TWr review comments --------- Co-authored-by: Danil.Pavlov <[email protected]> Co-authored-by: Sarah Haggarty <[email protected]> Co-authored-by: Sarah Haggarty <[email protected]> * feat: new features in memory manager (#4880) * feat: Kotlin 2.2.0 release details and What's new (#4897) * Kotlin 2.2.0 release details and What's new * Adding What's new 2.2.0 * chore: resolve conflict in kr.tree * chore: fix links * Andrey review * feat: legacy DCE deprecation (#4885) --------- Co-authored-by: Sarah Haggarty <[email protected]> Co-authored-by: Dániel Csorba <[email protected]> Co-authored-by: Danil Pavlov <[email protected]> Co-authored-by: Aleksey Zamulla <[email protected]> Co-authored-by: Mikhail Zarechenskiy <[email protected]> Co-authored-by: Andrey Polyakov <[email protected]> Co-authored-by: Sarah Haggarty <[email protected]>
No description provided.