Skip to content

update: updating compiler-reference with jvm-default #4915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

daniCsorbaJB
Copy link
Contributor

This PR is adding an entry to the compiler reference for jvm-default

@daniCsorbaJB daniCsorbaJB requested a review from a team as a code owner June 23, 2025 16:23
Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I suggest shortening the initial text as it can all be included in the table now :)

Comment on lines 275 to 277
Possible values are `enable`, `no-compatibility`, and `disable`.
The default value is `enable`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Possible values are `enable`, `no-compatibility`, and `disable`.
The default value is `enable`.


| Mode | Description |
|--------------------|-------------------------------------------------------------------------------------------------------------------------|
| `enable` | Generates default implementations in interfaces and includes bridge functions in subclasses and `DefaultImpls` classes. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enable` | Generates default implementations in interfaces and includes bridge functions in subclasses and `DefaultImpls` classes. |
| `enable` | Generates default implementations in interfaces and includes bridge functions in subclasses and `DefaultImpls` classes. (Default) |

Possible values are `enable`, `no-compatibility`, and `disable`.
The default value is `enable`.


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Collaborator

@sarahhaggarty sarahhaggarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniCsorbaJB daniCsorbaJB merged commit dee7fcb into master Jun 24, 2025
4 checks passed
@daniCsorbaJB daniCsorbaJB deleted the jvm-default-compiler-reference branch June 24, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants