-
Notifications
You must be signed in to change notification settings - Fork 47
Don't defer input evaluation to REPL backend #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can this have a test added to make sure this doesn't regress in the future? |
#308 was an attempt to fix these tests but it seems efforts have been abandoned since. |
@KristofferC can you approve CI? |
Nice! Thank you for attending to this. Can confirm that this works for me locally 🥳 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 51.03% 50.82% -0.22%
==========================================
Files 9 9
Lines 821 850 +29
==========================================
+ Hits 419 432 +13
- Misses 402 418 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests need to be updated for nightly and this is not tested anyway. |
Thanks @KristofferC! |
Fixes #373.
The fix implemented in #367 spawned a new task for the evaluation, but this eventually synchronized with the backend too (through a backend
Channel
), still causing a deadlock (or at least, in certain circumstances).This was largely inspired from JuliaDebug/Infiltrator.jl#139, which sidesteps backend synchronization entirely.