Remove unnecessary C.git_tree_entry_free calls ...

AaronO · AaronO · commit ee2a0238687f · 2017-02-25T02:13:57.000+01:00
As per the docs, these entries belong to the tree and don’t need to be freed by the caller: * https://libgit2.github.com/libgit2/#HEAD/group/tree/git_tree_entry_bynam e
diff --git a/tree.go b/tree.go
@@ -51,7 +51,6 @@ func (t Tree) EntryByName(filename string) *TreeEntry {
 	if entry == nil {
 		return nil
 	}
-	defer C.git_tree_entry_free(entry)
 
 	return newTreeEntry(entry)
 }
@@ -80,7 +79,6 @@ func (t Tree) EntryByIndex(index uint64) *TreeEntry {
 	if entry == nil {
 		return nil
 	}
-	defer C.git_tree_entry_free(entry)
 
 	return newTreeEntry(entry)
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ func (t Tree) EntryByName(filename string) *TreeEntry {`
`51`	`51`	`if entry == nil {`
`52`	`52`	`return nil`
`53`	`53`	`}`
`54`		`- defer C.git_tree_entry_free(entry)`
`55`	`54`
`56`	`55`	`return newTreeEntry(entry)`
`57`	`56`	`}`
`@@ -80,7 +79,6 @@ func (t Tree) EntryByIndex(index uint64) *TreeEntry {`
`80`	`79`	`if entry == nil {`
`81`	`80`	`return nil`
`82`	`81`	`}`
`83`		`- defer C.git_tree_entry_free(entry)`
`84`	`82`
`85`	`83`	`return newTreeEntry(entry)`
`86`	`84`	`}`