packdat/multiple signatures + improvements + eu digital signature compliant #7
Conversation
feat: multiple signatures by packdat
|
Hi @matheus-kirchesch Could you also open a PR to the original empira's PdfSharp repo? https://github.com/empira/PDFsharp |
| // Sign the byte range | ||
| var contentInfo = new ContentInfo(range); | ||
| var signedCms = new SignedCms(contentInfo, true); | ||
| var signer = new CmsSigner(options.Certificate)/* { IncludeOption = X509IncludeOption.WholeChain }*/; | ||
| signer.UnsignedAttributes.Add(new Pkcs9SigningTime()); |
There was a problem hiding this comment.
can't remember right now but I think there was a reason to have it as an unsigned attribute.
There was a problem hiding this comment.
I am not sure what this reason would be, but it makes sense to have it signed, it is the signature time and making it signed means it can not be changed
Sure, you mean after they merge this PR? empira#48 |
|
@matheus-kirchesch 6.2.0 has just been released and it now natively includes the signature part. I did not check yet if 6.2.0 already supports multiple signatures, but if it's not the case, work from @packdat and yours have to be rebased onto 6.2.0 in order to sync with native signature code. |
This PR is a continuation of the PR #5, I have made these changes to the custom PDF Sharp on our company private project, but thought of bringing it here also.