Skip to content

fix: consumer group consumer create request body to align with API spec #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

harshadixit12
Copy link
Contributor

@harshadixit12 harshadixit12 commented May 12, 2025

This PR fixes the request body sent while creating a consumer group consumer - we were sending an array of UUIDs in consumer field while according to API spec we should be sending a single UUID.
Fixes https://konghq.atlassian.net/browse/APIOPS-121

API spec for reference: https://docs.konghq.com/gateway/api/admin-ee/latest/#/operations/post-consumer_groups-group_name_or_id-consumers_with_workspace

Haven't added additional tests since there is already one - https://github.com/Kong/go-kong/blob/main/kong/consumer_group_consumer_test.go#L36
I have tested this on deck through integration and manual tests.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.72%. Comparing base (da4e510) to head (8ff1ae3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   51.74%   51.72%   -0.02%     
==========================================
  Files          74       74              
  Lines        6196     6194       -2     
==========================================
- Hits         3206     3204       -2     
  Misses       2372     2372              
  Partials      618      618              
Flag Coverage Δ
3.4 49.58% <100.00%> (-0.02%) ⬇️
3.7 48.43% <100.00%> (-0.02%) ⬇️
3.8 49.90% <100.00%> (-0.02%) ⬇️
3.9 50.00% <100.00%> (-0.02%) ⬇️
community 38.42% <0.00%> (+0.01%) ⬆️
enterprise 50.43% <100.00%> (-0.02%) ⬇️
integration 51.72% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshadixit12 harshadixit12 force-pushed the fix/consumer-group-consumer-req-body branch 2 times, most recently from a157c92 to 558cdfd Compare May 12, 2025 07:37
@harshadixit12 harshadixit12 force-pushed the fix/consumer-group-consumer-req-body branch from 558cdfd to 33cbd79 Compare May 12, 2025 09:44
@harshadixit12 harshadixit12 marked this pull request as ready for review May 12, 2025 10:22
@harshadixit12 harshadixit12 requested review from a team as code owners May 12, 2025 10:22
@harshadixit12 harshadixit12 requested a review from Prashansa-K May 12, 2025 10:23
@harshadixit12 harshadixit12 merged commit 6507c13 into main May 13, 2025
40 checks passed
@harshadixit12 harshadixit12 deleted the fix/consumer-group-consumer-req-body branch May 13, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants