Skip to content

Use the "UTC" identifier for the TimeZone.UTC time zone #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

dkhalanskyjb
Copy link
Collaborator

Fixes #474

@dkhalanskyjb dkhalanskyjb requested review from ilya-g and Copilot April 17, 2025 13:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

@@ -16,7 +16,7 @@ class TimeZoneTest {
fun utc() {
val utc: FixedOffsetTimeZone = TimeZone.UTC
println(utc)
assertEquals("Z", utc.id)
assertEquals("UTC", utc.id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check that TimeZone.UTC equals TimeZone.of("UTC")?

@dkhalanskyjb dkhalanskyjb force-pushed the dkhalanskyjb/rename-utc branch from 68471b9 to 055a9c8 Compare April 28, 2025 10:29
@dkhalanskyjb dkhalanskyjb merged commit 06b389b into master Apr 28, 2025
1 check passed
@dkhalanskyjb dkhalanskyjb deleted the dkhalanskyjb/rename-utc branch April 28, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeZone..of("UTC") isn't equal to TimeZone.UTC
2 participants