Skip to content

Suppress REDUNDANT_ELSE_IN_WHEN in ProtobufTaggedEncoder.encodeNull() #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Suppress REDUNDANT_ELSE_IN_WHEN in ProtobufTaggedEncoder.encodeNull() #2987

merged 1 commit into from
Apr 23, 2025

Conversation

lunakoly
Copy link
Member

KT-76635 makes this when exhaustive, and without the suppress our aggregate build for the corresponding branch fails.

@lunakoly
Suppress REDUNDANT_ELSE_IN_WHEN in `ProtobufTaggedEncoder.encodeNul…
7dcb068 
…l()`

^KT-76635 makes this `when` exhaustive, and without the suppress our aggregate
build for the corresponding branch fails.
@lunakoly lunakoly force-pushed the rr/lunakoly/data-flow-based-exhaustiveness branch from 6eddbe5 to 7dcb068 Compare April 15, 2025 15:14
@lunakoly lunakoly requested a review from sandwwraith April 15, 2025 15:20
@sandwwraith
Copy link
Member

And why exactly we need to replace dev repo? Current dev depends on stable 2.1.20

@lunakoly lunakoly changed the base branch from dev to kotlin-community/dev April 16, 2025 10:18
@lunakoly
Copy link
Member Author

Sorry, rebased the branch onto kotlin-community/dev, but forgot that it should be pushed separately. I've changed the base to kotlin-community/dev and I'll push a separate branch for dev with the last commit only

@lunakoly lunakoly mentioned this pull request Apr 16, 2025
Merged
@sandwwraith
Copy link
Member

PRs to kotlin-community/dev should be reviewed by @woainikk

@sandwwraith sandwwraith requested a review from woainikk April 16, 2025 10:31
@lunakoly lunakoly force-pushed the rr/lunakoly/data-flow-based-exhaustiveness branch from 3db618c to 318751f Compare April 17, 2025 13:08
@lunakoly lunakoly mentioned this pull request Apr 17, 2025
Closed
@lunakoly lunakoly force-pushed the rr/lunakoly/data-flow-based-exhaustiveness branch from 83c1c80 to 7dcb068 Compare April 22, 2025 13:15
@woainikk woainikk merged commit aa746ee into kotlin-community/dev Apr 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woainikk woainikk woainikk approved these changes

@sandwwraith sandwwraith Awaiting requested review from sandwwraith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunakoly @sandwwraith @woainikk