Kotlin User Projects: add kotlin_additional_cli_options and logging #2996
Conversation
| @@ -28,7 +37,7 @@ tasks.withType(KotlinCompilationTask::class).configureEach { | |||
| } | |||
|
|
|||
| allWarningsAsErrors = werrorEnabled | |||
|
|
|||
| logger.info("allWarningsAsErrors=$werrorEnabled") | |||
There was a problem hiding this comment.
Is this logging really needed?
There was a problem hiding this comment.
yes, that will allow us to make sure we use correct settings
There was a problem hiding this comment.
Aren't they visible in teamcity parameters?
There was a problem hiding this comment.
I mean, that's not exactly what I would want to see in the build log
There was a problem hiding this comment.
Maybe move it to Added Kotlin compiler flags section then?
There was a problem hiding this comment.
tasks.withType<KotlinCompilationTask<*>>().configureEach {
doFirst {
logger.info("Added Kotlin compiler flags: ${compilerOptions.freeCompilerArgs.get().joinToString(", ")}")
logger.info("Werror state: ${compilerOptions.allWarningsAsErrors.get()}")
}
}
| @@ -46,3 +55,9 @@ tasks.withType<Kotlin2JsCompile>().configureEach { | |||
| tasks.withType<KotlinNativeCompile>().configureEach { | |||
| compilerOptions { freeCompilerArgs.add("-Xpartial-linkage-loglevel=ERROR") } | |||
| } | |||
|
|
|||
| tasks.withType<KotlinCompilationTask<*>>().configureEach { | |||
| doFirst { | |||
There was a problem hiding this comment.
I suggest printing only the additional args if they were provided: if (kotlin_additional_cli_options?.isNotEmpty()) logger.info(...)
There was a problem hiding this comment.
I think it's useful to have all options in log. now it look like this:
Added Kotlin compiler flags: -Xexplicit-api=strict, -Xsuppress-version-warnings, -Xexpect-actual-classes, -P, plugin:org.jetbrains.kotlinx.serialization:disableIntrinsic=false, -Xreport-all-warnings, -Xrender-internal-diagnostic-names, -nowarn
…f all extra compiler flags
woainikk
force-pushed
the
bobova/compiler-options
branch
from
39dbc33 to
bf7299a
Compare
(https://youtrack.jetbrains.com/issue/KT-75078)](https://youtrack.jetbrains.com/issue/KT-75078)