More flexible Pulumi mutex #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to make the Pulumi mutex mechanism more flexible by adding an additional parameter so that the mutex branch name can be customized beyond just the stack name.
- Added an input variable (ADDITIONAL_MUTEX_SUFFIX) with a default empty value for configuring the mutex branch name.
- Updated the branch naming in the mutex step to include the additional suffix, and added an environment variable for the GitHub API token.
| @@ -98,7 +105,7 @@ jobs: | |||
| - name: Set up mutex # Github concurrency management is horrible, things get arbitrarily cancelled if queued up. So using mutex until github fixes itself. When multiple jobs are modifying cache at once, weird things can happen. possible issue is https://github.com/actions/toolkit/issues/658 | |||
| uses: ben-z/gh-action-mutex@{% endraw %}{{ gha_mutex }}{% raw %} | |||
| with: | |||
| branch: mutex-pulumi-${{ inputs.PULUMI_STACK_NAME }} | |||
| branch: mutex-pulumi-${{ inputs.PULUMI_STACK_NAME }}-${{ inputs.ADDITIONAL_MUTEX_SUFFIX }} | |||
There was a problem hiding this comment.
[nitpick] Appending a hyphen regardless of the suffix value may result in a trailing hyphen when the suffix is empty; consider conditionally appending the hyphen only when the ADDITIONAL_MUTEX_SUFFIX is provided.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
Sometimes just the stack name was making the mutex too restrictive in the pulumi-aws CI workflow
How does this change address the issue?
Adds additional parameter to customize mutex
What side effects does this change have?
None
How is this change tested?
Downstream repo
Other
Added picking up github API token secret from envvar