use structs in testhelper to reduce stack size #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
carmenjiawenc
approved these changes
Jul 4, 2024
0xtinkle
reviewed
Mar 20, 2025
| @@ -64,121 +64,127 @@ contract TestHelper is Test, OptionsHelper { | |||
| executorValueCap = _valueCap; | |||
| } | |||
|
|
|||
| struct EndpointSetup { | |||
There was a problem hiding this comment.
worth to add natspec comment?
/**
- @dev Structure to manage and store endpoint-related configurations.
- Used for setting up multiple endpoints in testing and deployment.
- @param endpointList Array of deployed endpoint contracts.
- @param eidList List of endpoint identifiers (EIDs).
- @param sendLibs Addresses of sending libraries for each endpoint.
- @param receiveLibs Addresses of receiving libraries for each endpoint.
- @param signers List of signer addresses for verification.
- @param priceFeed Reference to the deployed price feed contract.
*/
0xtinkle
reviewed
Mar 20, 2025
| PriceFeed priceFeed; | ||
| } | ||
|
|
||
| struct LibrarySetup { |
0xtinkle
reviewed
Mar 20, 2025
| } | ||
|
|
||
| EndpointSetup endpointSetup; | ||
|
|
||
| /** | ||
| * @dev setup the endpoints | ||
| * @param _endpointNum num of endpoints | ||
| */ | ||
| function setUpEndpoints(uint8 _endpointNum, LibraryType _libraryType) public { |
There was a problem hiding this comment.
/**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #42