Maintain font size in grading view #7525
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2025 21:34
…est test regarding saving font size to localStorage
|
Currently, I am working on a Jest test to see if when we visit the grading view, if the font size variable in localstorage is being used to set the state, font_size. |
There was a problem hiding this comment.
@donny-wong good work, I just left a few comments.
Regarding the remaining test cases, I suggest using a jest mock to return a particular value for the local storage when accessing text_viewer_font_size. See e.g. https://jestjs.io/docs/mock-functions.
| @@ -37,6 +37,10 @@ export class TextViewer extends React.PureComponent { | |||
| componentDidMount() { | |||
| this.highlight_root = this.raw_content.current.parentNode; | |||
|
|
|||
| if (localStorage.getItem("text_viewer_font_size") != null) { | |||
There was a problem hiding this comment.
in general, use triple-equals instead of double-equals in Javascript.
| @@ -37,6 +37,10 @@ export class TextViewer extends React.PureComponent { | |||
| componentDidMount() { | |||
| this.highlight_root = this.raw_content.current.parentNode; | |||
|
|
|||
| if (localStorage.getItem("text_viewer_font_size") != null) { | |||
| this.setState({font_size: Number(localStorage.getItem("text_viewer_font_size"))}); | |||
There was a problem hiding this comment.
let's do the Number parsing in a try-catch; if the number fails to parse, don't set state and instead delete the localStorage value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When the font size is modified by the user in the grading view for the editor, we want to maintain that size even when the browser is refreshed. To do this we store the font size in the browser's local storage, where we check for and apply it when the browser is refreshed.
...
Screenshots of your changes (if applicable)
This image shows where the editor's font size buttons are located:Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)