Skip to content

Symbol init cleanup 2 #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Symbol init cleanup 2 #691

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
35f6d61
WIP - separate PredefinedSymbol from Symbol ..
rocky Dec 19, 2022
4d49f6b
Clarify Symbol as per mmatera
rocky Dec 19, 2022
21a81ad
fix MakeBoxes[Infix[...]]
mmatera Dec 26, 2022
e8ca60a
MakeBoxes[Infix[...],form]-> Infix
mmatera Dec 26, 2022
a417f00
alternative implementation
mmatera Dec 26, 2022
889e9fc
moving do_eval_infix to be a non-member function in the same module.
mmatera Dec 26, 2022
94f2bb0
adding comment
mmatera Dec 26, 2022
11a7eec
Move towards segregating box from eval
rocky Dec 27, 2022
0d4ce19
Adjust builtins_precedence and doc parenthesize
rocky Dec 27, 2022
a43fd5e
PredefinedSymbol -> SymbolConstant...
rocky Dec 27, 2022
45c12c4
tweak docstring, more type annotations
rocky Dec 27, 2022
c4c1e6d
Residual mege changes to get this working again
rocky Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify Symbol as per mmatera 
Update builtin/atomic/symbols.py according to current standards.
  • Loading branch information
@rocky
rocky committed Jan 7, 2023
commit 4d49f6bb4830650c077d61bf04867e8ab4e0600b
12 changes: 8 additions & 4 deletions mathics/core/symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,13 +329,17 @@ def replace_slots(self, slots, evaluation) -> "Atom":


class Symbol(Atom, NumericOperators, EvalMixin):
"""
A Symbol is a kind of Atom that acts as a symbolic variable.
"""A Symbol is a kind of Atom that acts as a symbolic variable.

All Symbols have a name that can be converted to string.

A Variable Symbol is a ``Symbol``` that is associated with a ``Definition``
that determines its evaluation value.
A Variable Symbol is a ``Symbol``` that is associated with a
``Definition`` that has an ``OwnValue`` that determines its
evaluation value.

A Function Symbol, like a Variable Symbol, is a ``Symbol`` that is
also associated with a ``Definition``. But it has a ``DownValue``
that is used in its evaluation.

A Function Symbol, like a Variable Symbol, is a ``Symbol`` that is
also associated with a ``Definition``. But it has a ``DownValue``
Expand Down